Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change WPF and WinForms trim warnings to errors #19409

Merged
merged 2 commits into from
Jul 30, 2021
Merged

Change WPF and WinForms trim warnings to errors #19409

merged 2 commits into from
Jul 30, 2021

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 30, 2021

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@agocke agocke marked this pull request as ready for review July 30, 2021 05:29
@agocke agocke requested a review from LakshanF July 30, 2021 05:29
LakshanF
LakshanF approved these changes Jul 30, 2021
View reviewed changes
Copy link
Member

@LakshanF LakshanF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LakshanF LakshanF mentioned this pull request Jul 30, 2021
Open
@agocke agocke merged commit e73ed02 into dotnet:main Jul 30, 2021
@agocke agocke deleted the warn-to-error branch July 30, 2021 23:07
@ThomasGoulet73 ThomasGoulet73 mentioned this pull request Jan 3, 2022
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LakshanF LakshanF LakshanF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agocke @LakshanF